Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECO-4819] Fix Unable to enter presence channel while in suspended state error with usePresence #1781

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

VeskeR
Copy link
Contributor

@VeskeR VeskeR commented Jun 3, 2024

Similar to the fix in #1761 with Connection closed errors, we should avoid entering presence for specific channel states.

Resolves #1780

Function code supports calling `useChannelStateListener` with options
object and listener only, but there was not TypeScript type for such
overload.
…usePresence`

Similar to the fix in #1761 with
`Connection closed` errors, we should avoid entering presence for
specific channel states.

Resolves #1780
Copy link
Collaborator

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VeskeR VeskeR changed the title [ECO-4819] Fix use presence channel suspended error [ECO-4819] Fix Unable to enter presence channel while in suspended state error with usePresence Jun 3, 2024
@VeskeR VeskeR merged commit 00da243 into main Jun 3, 2024
12 checks passed
@VeskeR VeskeR deleted the 1780/fix-usePresence-channel-suspended-error branch June 3, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants